I looking on buying a larger tank and I saw a 40gal tall tank and a 40gal regular tank. What would be better to have a taller tank or a short and long tank

the short long rectangular tank would be better.

There's a tank called a 40 gallon breeder which fits the short long rectangle
description. That would work great for goldies. My local Petco has them for
$90 without any add ons.

for golidies, short and long is better for more areation...

cheers